Allow httpAdditionalHeaders to contain Strings or NSStrings #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool |
|
@swift-ci please test |
pushkarnk
pushed a commit
to pushkarnk/swift-corelibs-foundation
that referenced
this pull request
Sep 23, 2016
pushkarnk
pushed a commit
to pushkarnk/swift-corelibs-foundation
that referenced
this pull request
Sep 23, 2016
parkera
pushed a commit
that referenced
this pull request
Sep 26, 2016
* Test case to test TimeZone.localizedName * Allow httpAdditionalHeaders to contain Strings or NSStrings (#625) * Switch to Error from NSError for API conformance * Fix for a URLSession crash (SR-2630) * If present, pass URLRequest.httpBody to the dataTask (#633) * Set Content-Type to application/x-www-form-urlencoded for POST requests * Update NSURLSession.swift * Fix for SR-2631 and implementation of URLSession.finishTasksAndInvalidate * Allow numeric types in NSNumberFormatter.string(for:)[SR-2477] (#643) * Fix for [SR-2486] Crash in NSDictionary.description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSURLSessionConfiguration.httpAdditonalHeadersis declared to accept[AnyHashable:Any], but internally this maps to[String : String].Currently the code assumes that the
[AnyHashable:Any]actually only containsNSStrings, whereas on macOS/Darwin its acceptable for eitherNSStrings orStrings to be used.I've therefore updated
URLSession._Configuration.convertToStringString()to allow either and coerce to String if needed.